Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDoc-2882 ETL to Azure Queue Storage #1880

Merged
merged 25 commits into from
Aug 5, 2024

Conversation

Danielle9897
Copy link
Member

Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-2882/Document-ETL-to-Azure-Queue-Storage

Scope of work (create new article / add new info / fix...):

  • Fix the duplicate 'general info' article
  • Ongoing tasks operations article (required due to above bullet)
  • Ongoing tasks overview article (under Studio)
  • AQS ETL article (under Studio)
  • Queue ETL overview article (under Server)
  • ETL basics article
  • AQS ETL article (under Server)
  • Update Kafka & RabbitMQ articles (under Server) to match + Place common content in overview
  • ETL configuration article (under Server)
  • How to add a connection string
  • Get connection string
  • Remove connection string
  • Add ETL operation

* `loadTo<ExchangeName>(obj, 'routingKey')`
When omitting the attributes, default attribute values will be assigned.

* `loadTo<ExchangeName>(obj)`
Copy link
Member Author

@Danielle9897 Danielle9897 Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djordjedjukic
What should be written/explained for this overload ?


I will resolve this Q by combining this last overload with the second one,
since both options present 'lack of routingKey'

* This approach minimizes the risks associated with exposed credentials commonly found in connection strings and enables
more granular control through [Role-Based Access Controls](https://learn.microsoft.com/en-us/azure/role-based-access-control/).
* **Paswordless**
* This authorization method authorizes a dedicated machine and can only be used in self-hosted mode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this authorization method required the machine to be already authorized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to:
This authorization method requires the machine to be pre-authorized and can only be used in self-hosted mode.
Hope this is ok.

Copy link

@poissoncorp poissoncorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've left just a single comment over the authentication methods in AQS

* In this page:
* [Add an Azure Queue Storage connection string](../../../../server/ongoing-tasks/etl/queue-etl/azure-queue#add-an-azure-queue-storage-connection-string)
* [Authentication methods](../../../../server/ongoing-tasks/etl/queue-etl/azure-queue#authentication-methods)
* [Exmaple](../../../../server/ongoing-tasks/etl/queue-etl/azure-queue#example)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Exmaple](../../../../server/ongoing-tasks/etl/queue-etl/azure-queue#example)
* [Examaple](../../../../server/ongoing-tasks/etl/queue-etl/azure-queue#example)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


---

A sample script that process documents from the Orders collection:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A sample script that process documents from the Orders collection:
A sample script that processes documents from the Orders collection:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Danielle9897
Copy link
Member Author

Danielle9897 commented Jul 25, 2024

@djordjedjukic
so I added the AccountKey to the list of mandatory parms for the AQS Connection String in the latest commit here
(as @kalczur has checked its necessity in this pr comment

but... now I wonder...
shouldn't the code here (or in any other place) add a check that this param is provided ?

@djordjedjukic
Copy link

@djordjedjukic so I added the AccountKey to the list of mandatory parms for the AQS Connection String in the latest commit here (as @kalczur has checked its necessity in this pr comment

but... now I wonder... shouldn't the code here (or in any other place) add a check that this param is provided ?

AccountKey is included in the Connection string. The user doesn't input that separately. You can see that we are parsing the connection string using the method you provided.

If that is what you are asking?

@ppekrol ppekrol merged commit 6035c6c into ravendb:master Aug 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants