-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDoc-2944 OpenTelemetry Support #1883
Conversation
* **gRPC** protocol: | ||
|
||
* When using the gRPC transport protocol, the endpoint should be specified in the format | ||
`grpc://localhost:4317` (replace the default port 4317 with whatever port you are using). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you find it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that from here:
https://opentelemetry.io/docs/specs/otel/protocol/exporter/
And I think I should refine that text to be more accurate:
=>
When using the default settings for the OpenTelemetry Collector with the gRPC transport protocol,
the endpoint should be specified in the format grpc://localhost:4317
(replace the default port 4317 with whatever port you are using).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-2944/Review-Open-Telemetry-documentation