Skip to content

Conversation

@16AbhishekAnand
Copy link
Collaborator

No description provided.

@ravikg ravikg self-requested a review March 26, 2023 15:04
@@ -1,4 +1,4 @@
package com.aoc.days;
//package com.aoc.days;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you commented this?

Stream<String> lines = Files.lines(Path.of("src/main/resources/day1.txt"));
// Stream<String> lines = Files.lines(Path.of(Day1.class.getClassLoader().getResource("day1.txt").toURI()));
// lines.forEach(System.out::println);
Stream<String> lines = Files.lines(Path.of("day1.txt"));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is done?

import java.util.concurrent.atomic.AtomicLong;
import java.util.stream.Stream;

public class Day1a {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part 2? then use a better class name: Day1P2 or Day1Part2 etc.

//b = y = papr = 2 win = 6 and loosse = 0
//c = z = scissior = 3 draw =3

public class Day2 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. draw = true -> end
  2. draw = false -> win = false -> user wins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants