Skip to content

Commit

Permalink
scoped env
Browse files Browse the repository at this point in the history
Signed-off-by: dentiny <[email protected]>
  • Loading branch information
dentiny committed Feb 11, 2025
1 parent e2bfd98 commit babd0bb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions src/ray/util/tests/pipe_logger_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@ namespace {
constexpr std::string_view kLogLine1 = "hello\n";
constexpr std::string_view kLogLine2 = "world\n";

class PipeReadBufferSizeSetter {
public:
explicit PipeReadBufferSizeSetter(size_t pipe_buffer_size) {
setEnv("RAY_pipe_logger_read_buf_size", absl::StrFormat("%d", pipe_buffer_size));
}
~PipeReadBufferSizeSetter() { unsetEnv("RAY_pipe_logger_read_buf_size"); }
};

class PipeLoggerTest : public ::testing::TestWithParam<size_t> {};

TEST_P(PipeLoggerTest, RedirectionTest) {
Expand Down
2 changes: 1 addition & 1 deletion src/ray/util/tests/spdlog_newliner_sink_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ std::shared_ptr<spdlog::logger> CreateLogger() {
return logger;
}

// Testing senario: Keep writing to spdlog after flush, and check whether all written
// Testing scenario: Keep writing to spdlog after flush, and check whether all written
// content is correctly reflected.
TEST(NewlinerSinkTest, WriteAfterFlush) {
auto logger = CreateLogger();
Expand Down

0 comments on commit babd0bb

Please sign in to comment.