Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow customizing session name #46281

Open
han-steve opened this issue Jun 26, 2024 · 2 comments
Open

[Core] Allow customizing session name #46281

han-steve opened this issue Jun 26, 2024 · 2 comments
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@han-steve
Copy link

Description

Currently, the session name for a ray cluster is set to session_{timestamp}_{pid} (documentation), which is hard to retrieve/predict. We want to provide users the Grafana metrics for their KubeRay ray cluster, but we don't know what the SessionName label filter should be set to. If we can customize the session name as a command-line argument to ray start, we can generate a unique name and pass it to the Kuberay as RayStartParams. Then, we can easily filter the prometheus metrics with this name.

There is another thread for a similar request for a different reason: https://discuss.ray.io/t/how-to-change-the-ray-session-name-format/9217

Use case

Another solution to our use case is to have the KubeRay operator find this session name and surface it to the RayCluster CRD. If this is preferred, I can open an issue in the KubeRay repo.

@han-steve han-steve added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 26, 2024
@enori
Copy link
Contributor

enori commented Jun 27, 2024

Hi, I would like to take on this issue.
I'm a begginer to this project and open-source contributions, but I'm eager to learn and contribute if necessary.
Thanks!

@anyscalesam anyscalesam added the core Issues that should be addressed in Ray Core label Jul 8, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 8, 2024
@jjyao
Copy link
Collaborator

jjyao commented Aug 16, 2024

There is code that depends on the session name being this particular format. I think it's safer to retrieve the ray auto generated session name and expose it to the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

4 participants