Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add ray-start option 'session-name' #46404

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

enori
Copy link
Contributor

@enori enori commented Jul 3, 2024

Why are these changes needed?

Currently, the session name for a ray cluster is set to session_{timestamp}_{pid} (documentation), which is hard to retrieve/predict. We want to provide users the Grafana metrics for their KubeRay ray cluster, but we don't know what the SessionName label filter should be set to. If we can customize the session name as a command-line argument to ray start, we can generate a unique name and pass it to the Kuberay as RayStartParams. Then, we can easily filter the prometheus metrics with this name.

Related issue number

#46281

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@enori enori marked this pull request as ready for review July 3, 2024 08:00
@enori enori requested a review from a team as a code owner July 3, 2024 08:00
@enori enori changed the title Add ray-start option 'session-name' [Core] Add ray-start option 'session-name' Jul 3, 2024
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need review from core folks

@can-anyscale can-anyscale requested a review from a team August 15, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants