Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Cover cpplint for ray/tree/master/src/ray/gcs/gcs_server #51184

Open
Ziy1-Tan opened this issue Mar 8, 2025 · 1 comment · May be fixed by #51197
Open

[core] Cover cpplint for ray/tree/master/src/ray/gcs/gcs_server #51184

Ziy1-Tan opened this issue Mar 8, 2025 · 1 comment · May be fixed by #51197
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability

Comments

@Ziy1-Tan
Copy link

Ziy1-Tan commented Mar 8, 2025

Description

As part of the initiative to introduce cpplint into the pre-commit hook, we are gradually cleaning up C++ folders to ensure compliance with code style requirements. This issue focuses on cleaning up /src/ray/gcs/gcs_server.

Goal

Ensure all .h and .cc files in /src/ray/gcs/gcs_server comply with cpplint rules.
Address or suppress all cpplint warnings.

Steps to Complete

  • Checkout the latest main branch and install the pre-commit hook.
  • Manually modify all C++ files in /src/ray/gcs/gcs_server to trigger cpplint (e.g., by adding a newline).
  • Run git commit to trigger cpplint and identify issues.
  • Fix the reported issues or suppress them using clang-tidy if necessary.

This is a sub issue from #50583

@Ziy1-Tan Ziy1-Tan linked a pull request Mar 9, 2025 that will close this issue
8 tasks
@dentiny
Copy link
Contributor

dentiny commented Mar 9, 2025

Thank you so much for the help!

@dentiny dentiny added enhancement Request for new feature and/or capability core Issues that should be addressed in Ray Core labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants