[core] Cover cpplint for ray/tree/master/src/ray/gcs/gcs_server
#51197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey,@dentiny. Would you mind to take a look:) |
dentiny
reviewed
Mar 9, 2025
|
|
||
| #include "ray/stats/metric.h" | ||
|
|
||
| DEFINE_stats(health_check_rpc_latency_ms, | ||
| "Latency of rpc request for health check.", | ||
| (), | ||
| ({1, 10, 100, 1000, 10000}, ), | ||
| ({1, 10, 100, 1000, 10000}, ), // NOLINT |
There was a problem hiding this comment.
src/ray/gcs/gcs_server/gcs_health_check_manager.cc:24: Extra space before ) [whitespace/parens] [2]Sounds reasonable to me, maybe we just remove the space? Curious does it work if we make it
({1, 10, 100, 1000, 10000}),
dentiny
reviewed
Mar 9, 2025
There was a problem hiding this comment.
Code change LGTM, could you please change the precommit file as well?
Line 50 in e7268f2
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Sure. |
|
Linter check seems to fail for premerge, could you please fix it? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ensure all .h and .cc files in
src/ray/gcs/gcs_servercomply with cpplint rules.This is the command that I had ran and the console output
Related issue number
Closes #51184
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.