Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Autoscaler] Refactor v2 Log Formatting #49350

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ryanaoleary
Copy link
Contributor

@ryanaoleary ryanaoleary commented Dec 19, 2024

Why are these changes needed?

Currently the V2 Autoscaler formats logs by converting the V2 data structure ClusterStatus to the V1 structures AutoscalerSummary and LoadMetricsSummary and then passing them to the legacy format_info_string. It'd be useful for the V2 autoscaler to directly format ClusterStatus to the correct output log format. This PR refactors utils.py to directly format ClusterStatus. Additionally, this PR changes the node reports to output instance_id rather than ip_address, since the latter is not necessarily unique for failed nodes.

Related issue number

Closes #37856

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ryanaoleary ryanaoleary changed the title Initial commit to refactor v2 format code [Core][Autoscaler] Refactor v2 format code Dec 19, 2024
@ryanaoleary ryanaoleary changed the title [Core][Autoscaler] Refactor v2 format code [Core][Autoscaler] Refactor v2 Log Formatting Dec 19, 2024
@ryanaoleary ryanaoleary force-pushed the refactor-v2-logs branch 2 times, most recently from 7589e14 to 30fe22c Compare January 3, 2025 02:37
@ryanaoleary ryanaoleary marked this pull request as ready for review February 13, 2025 00:44
@ryanaoleary ryanaoleary requested review from hongchaodeng and a team as code owners February 13, 2025 00:44
@ryanaoleary
Copy link
Contributor Author

cc: @rickyyx, I think I'm going to add some different unit test cases but this should be good to review

Signed-off-by: Ryan O'Leary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoscaler] Refactor ray status output code
1 participant