Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Fix read file error when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD #50178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[data] Fix read file error when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD #50178

wants to merge 1 commit into from
+34 −5

Conversation

Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Feb 2, 2025 •
edited
Loading

fix #50080

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Jay-ju Jay-ju requested a review from a team as a code owner February 2, 2025 06:22
@Jay-ju Jay-ju changed the title [data] Fix the issue when file URLs are from HTTP and the number exce… [data] Fix the issue when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD Feb 2, 2025
@Jay-ju
[data] Fix the issue when file URLs are from HTTP and the number exce…
c8ccdd5 
…eds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD

Signed-off-by: jukejian <[email protected]>
@Jay-ju Jay-ju changed the title [data] Fix the issue when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD [data] Fix when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD Feb 2, 2025
@Jay-ju Jay-ju changed the title [data] Fix when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD [data] Fix read file error when file URLs are from HTTP and the number exceeds FILE_SIZE_FETCH_PARALLELIZATION_THRESHOLD Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] read_json does not work for 16 or more URLs
1 participant
@Jay-ju