[core] spdlog newliner sink #50333
Merged
[core] spdlog newliner sink #50333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/spdlog-newliner-sink
branch
3 times, most recently
from
c322959 to
918d520
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/spdlog-newliner-sink
branch
from
918d520 to
d123679
Compare
jjyao
reviewed
Feb 9, 2025
| return; | ||
| } | ||
| std::vector<std::string_view> segments = absl::StrSplit(new_content, '\n'); | ||
| for (int idx = 0; idx < static_cast<int>(segments.size()) - 1; ++idx) { |
There was a problem hiding this comment.
It's safer to use int, because segment could be empty, then possible to suffer underflow.
There was a problem hiding this comment.
I don't think it can be empty in our case but ok.
| std::vector<std::string_view> segments = absl::StrSplit(new_content, '\n'); | ||
| for (int idx = 0; idx < static_cast<int>(segments.size()) - 1; ++idx) { | ||
| std::string cur_message = std::move(buffer_); | ||
| buffer_.clear(); |
There was a problem hiding this comment.
is it safe to call clear on a moved string and use it later? Should we do buffer_ = "" instead?
There was a problem hiding this comment.
is it safe to call clear on a moved string and use it later?
What do you mean? I didn't access its value. clear is a well-defined function.
Signed-off-by: dentiny <[email protected]>
jjyao
approved these changes
Feb 10, 2025
| return; | ||
| } | ||
| std::vector<std::string_view> segments = absl::StrSplit(new_content, '\n'); | ||
| for (int idx = 0; idx < static_cast<int>(segments.size()) - 1; ++idx) { |
There was a problem hiding this comment.
I don't think it can be empty in our case but ok.
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: dentiny <[email protected]>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: dentiny <[email protected]>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
Signed-off-by: dentiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new sink, which logs and flushes on newliner basis.
I plan to use it as a wrapper for rotation file sink around rotation file sink.