[core] Implement get or create for lru cache #50347
Open
+124
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/get-or-create-lru
branch
from
839a964 to
d73db67
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
changed the title
|
@dayshah could you review this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a TODO item on
GetOrCreatefeature for LRU cache (which is suggested by @dayshah before), and apply it to core worker.The reason to revisit it here is, I found large number of task creation at the beginning meanwhile at roughly the same time leads to unnecessary repeated computation.
But overall this PR is not intended to be an optimization latency wise, just to save possible recomputation.
Performance impact based on
many_taskstest: