-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Don't build cpp api on pip install #50499
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: dayshah <[email protected]>
@@ -33,6 +33,7 @@ | |||
|
|||
ROOT_DIR = os.path.dirname(__file__) | |||
BUILD_JAVA = os.getenv("RAY_INSTALL_JAVA") == "1" | |||
BUILD_CPP = os.getenv("RAY_INSTALL_CPP") == "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will break release wheel building? at least this is a behavior change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 123 to 124 in 02d3f3c
if os.getenv("RAY_INSTALL_CPP") == "1": | |
# "ray-cpp" wheel package. |
wouldn't cpp wheel building go down this path anyways and RAY_INSTALL_CPP has to be true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. you are right that when we are building for releases, we always set RAY_INSTALL_CPP=1
already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. you are right that when we are building for releases, we always set
RAY_INSTALL_CPP=1
already.
well, no, actually, RAY_INSTALL_CPP
is used to toggle if to build the ray
package or the ray-cpp
package. it is not for controlling the cpp header files are built.
Why are these changes needed?
Don't want to build the cpp api when using the
pip install -e . --verbose
commandRelated issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.