Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Don't build cpp api on pip install #50499

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Feb 12, 2025

Why are these changes needed?

Don't want to build the cpp api when using the pip install -e . --verbose command

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@dayshah dayshah requested review from dentiny and aslonnie February 12, 2025 23:12
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Feb 12, 2025
@dayshah dayshah changed the title [core] dont build cpp api on pip install [core] Don't build cpp api on pip install Feb 12, 2025
@@ -33,6 +33,7 @@

ROOT_DIR = os.path.dirname(__file__)
BUILD_JAVA = os.getenv("RAY_INSTALL_JAVA") == "1"
BUILD_CPP = os.getenv("RAY_INSTALL_CPP") == "1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break release wheel building? at least this is a behavior change.

Copy link
Contributor Author

@dayshah dayshah Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ray/python/setup.py

Lines 123 to 124 in 02d3f3c

if os.getenv("RAY_INSTALL_CPP") == "1":
# "ray-cpp" wheel package.

wouldn't cpp wheel building go down this path anyways and RAY_INSTALL_CPP has to be true

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. you are right that when we are building for releases, we always set RAY_INSTALL_CPP=1 already.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. you are right that when we are building for releases, we always set RAY_INSTALL_CPP=1 already.

well, no, actually, RAY_INSTALL_CPP is used to toggle if to build the ray package or the ray-cpp package. it is not for controlling the cpp header files are built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants