[core] Mask rllib directory for core tests #50618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
…es/mask-data-dir
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
aslonnie
reviewed
Feb 14, 2025
ci/ray_ci/tests.env.Dockerfile
Outdated
| @@ -31,6 +31,9 @@ fi | |||
|
|
|||
| if [[ "$RAY_INSTALL_MASK" != "" ]]; then | |||
| echo "--- Apply mask: $RAY_INSTALL_MASK" | |||
| if [[ "$RAY_INSTALL_MASK" =~ rllib ]]; then | |||
| rm -rf python/ray/rllib | |||
There was a problem hiding this comment.
the real rllib is under ./rllib
There was a problem hiding this comment.
Oh I thought the symlink was reversed -- maybe remove both just in case?
There was a problem hiding this comment.
yep, remove both.
we reversed the dashboard one
./rllib symlink reversing is deferred because we have hundreds of links in rllib docs that are pointing to files on github master branch..
Signed-off-by: Edward Oakes <[email protected]>
…es/mask-rllib-dir
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
…es/mask-rllib-dir
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
…es/mask-rllib-dir
|
@aslonnie ready for review, other PRs merged |
aslonnie
approved these changes
Mar 8, 2025
|
Blocked on: #51183 (last one I hope!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove
python/ray/rllib/directory during core tests to enforce componentization.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.