[RLlib] Adjust callback validation to account for MultiCallback.
#50920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added a test for callbacks. Signed-off-by: simonsays1980 <[email protected]>
sven1977
reviewed
Feb 26, 2025
| @@ -0,0 +1,131 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
Very nice! Let's add this to BUILD ...
sven1977
reviewed
Feb 26, 2025
rllib/algorithms/algorithm_config.py
Outdated
| "returns a subclass of DefaultCallbacks, got " | ||
| f"{callbacks_class}!" | ||
| ) | ||
| if isinstance(callbacks_class, list): |
There was a problem hiding this comment.
nit: Can we simplify a bit?
Something like:
from ray.rllib.utils import force_list
to_check = force_list(callbacks_class)
if not all(callable(cc) for cc in to_check):
raise ValueError ...
Avoids the many if blocks.
sven1977
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
LGTM. Just one nit and to add to BUILD. Thx @simonsays1980 !
sven1977
changed the title
MultiCallback.MultiCallback.
…d the test to the BUILD file and removed an if-clause. Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The validation of
Algorithm.callbackswas expecting solely aCallablefromcallback_class. For aMultiCallbackusers can, however, pass inList[RLlibCallback]. The latter was running into a validation error. This PR fixes this bug and adds a test for callbacks to the CI suite.Related issue number
Closes #48089
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.