[core] Integrate process-wise cgroup setup with task execution #51107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/cgroup-in-worker
branch
from
b455ac4 to
0165015
Compare
|
I'm confused -- why are we writing any code for per-task cgroups when we haven't scoped out the proposed changes yet? |
I've discussed with @israbbani offline on scope and implementation, and I think most of things are clear now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up cgroup for a running task before its execution, and cleans up after execution.
It's a noop change to production, because noop cgroup setup is used as of now.