Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat][Core] Re-implement dashboard subprocess modules with aiohttp server/client #51172

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

[Feat][Core] Re-implement dashboard subprocess modules with aiohttp server/client #51172

wants to merge 52 commits into from

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Mar 7, 2025 •
edited
Loading

Why are these changes needed?

Based on #49864 and try to convert subprocess module framework to aiohttp server/client over Unix sockets and Windows named pipe.

Still WIP.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

rynewang and others added 30 commits January 8, 2025 22:12
@rynewang
initial
2b6b729 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
split
a945a42 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
redo health check with regular messages, now it takes a request ID.
d161548 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix tests and default routes
5f17eba 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
streaming support (without exc handling)
d994687 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
Merge remote-tracking branch 'origin/master' into dash-procs
08bb903 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang @MortalHappiness
Update python/ray/dashboard/subprocesses/module.py
6a435cf 
Co-authored-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
thread safe dict
9c8272d 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
import bad
4b43962 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
rename methods
0075c8d 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
add logging
ac7e0b9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
rename and new event loop
b155df5 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix
f0dc835 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
exception handling in stream
2defd09 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix test
5b85a36 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
Merge remote-tracking branch 'origin/master' into dash-procs
6cad47b 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
lint
06381d8 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix test
5102da0 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
Merge remote-tracking branch 'origin/master' into dash-procs
eede87b 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
health check.
f1d37ce 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
docs
0e81b81 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
declare ourselves non minimal.
2aff055 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
add gandalf the grey, and some renames
03228a9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
make test log more robust by removing lineno
31ea86e 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
type annotations, docs
9e28dc9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
add to head.py
322ef0f 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
support minimal
9df07aa 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
make HealthzHead non minimal.
276be83 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
Merge remote-tracking branch 'origin/master' into dashboard-procs-int…
18b1288 
…egration

Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix
dd6b2ad 
Signed-off-by: Ruiyang Wang <[email protected]>
rynewang added 12 commits January 21, 2025 22:19
@rynewang
remove optional comments
d6cccdf 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
incarnation aware logs
dadb79f 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix abstract class, and a multi_get optimization
89d14a0 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix tests
d4dbeb9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
add thread name
e36a2c9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
rename health_check
be12cc6 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
reorg to keep module init in a single async func
80c8db1 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
kill subproc on destroy, setproctitle
be8e80b 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
signum, frame
a71d17e 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
add parent process liveness check
34886f7 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
fix tests
e47c4a9 
Signed-off-by: Ruiyang Wang <[email protected]>
@rynewang
spawn for linux
5b9fe6a 
Signed-off-by: Ruiyang Wang <[email protected]>
@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Mar 8, 2025
rynewang and others added 10 commits March 8, 2025 10:48
@rynewang @MortalHappiness
Merge branch 'master' into dashboard-procs-integration
e1862bb
@rynewang @MortalHappiness
lint
323e0e7 
Signed-off-by: Ruiyang Wang <[email protected]>
@MortalHappiness
[Feat][Core] Re-implement dashboard subprocess modules with aiohttp s…
eaced59 
…erver/client

Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
WIP: test
defa8a4 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Remove ThreadSafeDict
b6f7719 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Add repr for BindInfo
f2500af 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Fix route binding
4c63abe 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Fix http tests
5f4a4cf 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Fix remaining http tests except for websocket tests
354af07 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness
Support stream response
1674de8 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness force-pushed the feature/dashboard-aiohttp-server-client branch from 8b891c9 to 1674de8 Compare March 8, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw will be requested when the pull request is marked ready for review richardliaw is a code owner

@rkooo567 rkooo567 Awaiting requested review from rkooo567 rkooo567 will be requested when the pull request is marked ready for review rkooo567 is a code owner

@jjyao jjyao Awaiting requested review from jjyao jjyao will be requested when the pull request is marked ready for review jjyao is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MortalHappiness @rynewang