[core][refactor] Move node_stats_to_dict to utils.py to avoid importing unnecessary modules
#51187
+31
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
dentiny
approved these changes
Mar 9, 2025
MortalHappiness
approved these changes
Mar 9, 2025
edoakes
reviewed
Mar 9, 2025
python/ray/dashboard/utils.py
Outdated
| @@ -358,6 +358,31 @@ def address_tuple(address): | |||
| return ip, int(port) | |||
|
|
|||
|
|
|||
| def node_stats_to_dict(message): | |||
There was a problem hiding this comment.
the type hint is derived from the return type of node_stats.
ray/python/ray/_private/internal_api.py
Line 92 in 2f8684f
edoakes
reviewed
Mar 9, 2025
Comment on lines
+382
to
+383
| finally: | ||
| message.core_workers_stats.extend(core_workers_stats) |
There was a problem hiding this comment.
do you know why this is in a finally block? very strange pattern
There was a problem hiding this comment.
- The function first clears the field
core_workers_statsfrom the message. - It converts the message into a dict and constructs
result["coreWorkersStats"]. finally: if step (2) throws an exception, the fieldcore_workers_statsis set back on the message to avoid side effects.
Signed-off-by: kaihsun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
node_stats_to_dictis used by bothmemory_utils.pyandnode_head.py, andmemory_utils.pyimportsray.dashboard.modules.node.node_head. It's better to avoid having a "utils" module import other internal Python modules to avoid nested import or potential circular import.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.