Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Making Object Store Fallback Directory Configurable #51189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MengjinYan
Copy link
Collaborator

Why are these changes needed?

Recently we investigated issue where a job ran out of disk because the fallback directory is full. Currently, the fallback directory is set to /tmp folder which might have a size constraint and is not able to let the job to use the full disk when it is necessary.

This PR make the fallback directory configurable so that it can be configured to a larger disk space when it is needed. The configuration is done by setting the --fallback-directory option in the ray start command.

The PR is manually tested:

  1. When running ray start without the config:
ray start --head

The fallback directory is set to /tmp in raylet.out:

[2025-03-08 19:50:31,664 I 31368 35096955] (raylet) dlmalloc.cc:321: Setting dlmalloc config: plasma_directory=/tmp, fallback_directory=/tmp, hugepage_enabled=0, fallback_enabled=1
  1. When running ray start with the config:
ray start --head --fallback-directory="/tmp/fallback"

The fallback directory is set to /tmp/fallback in raylet.out:

[2025-03-08 20:23:25,279 I 61733 35267407] (raylet) dlmalloc.cc:321: Setting dlmalloc config: plasma_directory=/tmp, fallback_directory=/tmp/fallback, hugepage_enabled=0, fallback_enabled=1

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MengjinYan MengjinYan added the go add ONLY when ready to merge, run all tests label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant