[core] Make testable stream redirection #51191
Open
+301
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/testable-stream-redirection
branch
from
d52564e to
b333b43
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/testable-stream-redirection
branch
from
b333b43 to
bbab2c0
Compare
Signed-off-by: dentiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked upon #51179, to make redirection stream unit testable.
Basically a no-op change, to extract redirection logic out into a separate file, and leave exit hook and global registry where they're now.