Avoid setup-dev.py
writing to generated/
#51194
Open
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#48793 assumes that the
ray/serve/generated
directory does not exist in the Ray directory, which means that users have not compiled Ray in that directory.However, this approach is incorrect for developers who want to test code changes in KubeRay. The workflow is like:
ray/serve/generated
should be created after compilation.python3 setup-dev.py -y
to replace the Ray package with your local Ray code..../site-packages/ray/serve/generated
directory to a temporary directory, and then move it back after the soft link is created. However, in this case,ray/serve/generated
directory has already existed.In addition, in the Dockerfile, the
ray
directory is added by the commandADD . ray
, so the owner isroot
instead ofray
. That's why we see the permission error above.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.