[tune] Fix RunConfig deprecation message in Tune being emitted in trainer.fit usage
#51198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
requested review from
hongpeng-guo,
matthewdeng,
raulchen and
woshiyyya
as code owners
justinvyu
commented
Mar 9, 2025
Comment on lines
+140
to
+142
| if self._entrypoint == AirEntrypoint.TUNER and not isinstance( | ||
| self._run_config, ray.tune.RunConfig | ||
| ): |
There was a problem hiding this comment.
I did this instead of "casting" ray.train.RunConfig -> ray.tune.RunConfig because doing that would still emit the warning on the restoration flow and it was complicated to fix the problem for that case too. Adding this entrypoint condition + moving it to the "start from scratch" codepath solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Train V1 creates a
Tunerwhen callingtrainer.fit(). TheTrainerinstance passes its ownray.train.RunConfigto Tune, which now emits a deprecation warning message about how the Tuner should take in aray.tune.RunConfig. This warning should not be emitted in this case.