[core][autoscaler] add start_node_delay_s config to the FakeMultiNodeProvider for testing edge cases of idle_timeout_minutes #51201
+29
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
fake-node-provider-delay
branch
5 times, most recently
from
37c1dbd to
a0ebab6
Compare
…ider for testing edge cases of idle_timeout_minutes Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
fake-node-provider-delay
branch
from
a0ebab6 to
32b1c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need the delay function to reproduce the issue (#50783) mentioned in #51122, so that we can make a python test for it to avoid regressions.
Related issue number
#50783
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.