[core] Acquire GIL before calling PyGILState_Release #51203
+14
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For Python/CPython, the GIL should be automatically released and reacquired at every switch interval. However, Cython somehow interferes with the GIL, so when we try to call
PyGILState_Release
to release a thread, the following error message is displayed:The error message shows that the current thread (which holds the GIL) is the main thread, but we are trying to release another thread (i.e. default executor). The CPython source code shows that this means that the default executor doesn't hold GIL at that time.
In this PR, we explicitly acquire GIL when we call
PyGILState_Release
.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.