Update --labels and add --labels-from-file options for Label Selector API
#51706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
17 tasks
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
8 tasks
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
MengjinYan
reviewed
Mar 27, 2025
python/ray/scripts/scripts.py
Outdated
| default="{}", | ||
| type=str, | ||
| help="a JSON serialized dictionary mapping label name to label value.", | ||
| help="a JSON serialized dictionary mapping label name to label value sourced from a file.", |
There was a problem hiding this comment.
In the REP here: https://github.com/ray-project/enhancements/pull/60/files#diff-8ffbf04d141c252596eb1746813e1a8ea927b710fb74d252e11eba7c886c02a6R140, it mentioned that the content will be in YAML format. Wondering should we follow that or we want to update it to json?
There was a problem hiding this comment.
Done in b6e99ea, I changed it to read from file.
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates the
--labelsoption toray startorray initto accept a string list of key-value pairs mapping label names to label values. Labels follow Kubernetes label syntax. This PR also adds a--labels-from-fileargument to support sourcing labels from a file. Files are expected to contain a valid JSON string containing a serialized key-value pair map. We useparse_node_labels_jsonto parse the argument passed to--labels-from-file.Related issue number
#51564
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.