-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Serve] Add label_selector and bundle_label_selector to Serve API
#57694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanaoleary
wants to merge
67
commits into
ray-project:master
Choose a base branch
from
ryanaoleary:add-label-selector-serve-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,523
−89
Open
Changes from 43 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
ab6cd99
Add label_selector and bundle_label_selector to Serve API
ryanaoleary 0a449e1
Fix argument order
ryanaoleary a900e41
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 6862eee
Merge branch 'master' into add-label-selector-serve-option
zcin a0c2246
Add fallback strategy to serve options and consider labels during rep…
ryanaoleary c74a0e8
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 6a4d241
Add new fields to DeploymentVersion proto
ryanaoleary a1e5fd1
Add validation check that bundles are provided with bundle_label_sele…
ryanaoleary 0ba9ed7
Correctly handle label constraint for replica actor compaction
ryanaoleary 181156b
Fix fallback strategy type
ryanaoleary be6fdf1
mock correct flag in test
ryanaoleary 4558c47
Fix test, move some to unit, and remove NodeLabelSchedulingStrategy c…
ryanaoleary b0eae3a
Update python/ray/serve/_private/config.py
ryanaoleary 8b72f0c
Fix argument names, refactor test fixture, and improve readability
ryanaoleary 248be33
Remove fallback_strategy from Deployment API
ryanaoleary 3ddb0a1
Add new fields to to_dict
ryanaoleary a9dbec0
Fully remove fallback strategy from deployment API
ryanaoleary d96f858
Fix var names and tests
ryanaoleary db162af
Move appropriate tests to deployment_scheduler and remove duplicate test
ryanaoleary 935e084
Handle Label selector set to None
ryanaoleary d080190
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary d87f838
Move back actor_options copy to where it was
ryanaoleary 31bd7d8
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary fe6a1a7
Fix invalid parameter being passed as placement_group_version
ryanaoleary 40c02e0
Add string type check to _filter_nodes_by_labels
ryanaoleary 4305e20
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 7b13cc5
Fix None check for fallback strategy
ryanaoleary fe1eb88
pass bundle_label_selector through config override path
ryanaoleary f4e90a4
Update python/ray/serve/schema.py
ryanaoleary fc52d16
Add TODO comments
ryanaoleary b844884
Fix field name that gets popped
ryanaoleary 47ed24d
Refactor schedule function to be more clear
ryanaoleary 4f438f4
Add unit test coverage for bundle_label_selector and fallback_strateg…
ryanaoleary 485dde1
Refactor is_scaled_copy_of for readability and add attribute checks
ryanaoleary 38d4d30
make variable assignments more readable
ryanaoleary 06c23f5
Prevent fallback_strategy from getting overwritten
ryanaoleary 4a771c1
Fix explicit null bundles in fallback causes crash
ryanaoleary 5fc10e7
Add validation test for validate_bundle_label_selector
ryanaoleary 0b294cc
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary cb78cc2
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary a55af8e
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary 5e8f85e
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary 3128161
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary 51dd705
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary 45dd5aa
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary c213408
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary dc59988
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary fc79d5a
Update python/ray/serve/_private/deployment_scheduler.py
ryanaoleary 802bd5e
Fix naming from suggested comments
ryanaoleary cde9d08
Fix version truthiness check
ryanaoleary 656986d
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 010827f
Move filter by label selector logic to label_utils
ryanaoleary 1e3a074
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 89d4390
Fix key names and add NotImplementedError
ryanaoleary bc76515
Fix test key
ryanaoleary 3c7c07f
Update python/ray/tests/test_label_utils.py
ryanaoleary 206a89d
Trim whitespace around selector and fix invalid test case
ryanaoleary 8cd0b0b
Add more test cases and re-structure under relevant classes
ryanaoleary 21bd155
Enable single bundle_label_selector to apply to all bundles and add t…
ryanaoleary 9f8d570
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary 56f8bdf
Fix validate_bundle_label_selector for single selector case
ryanaoleary a9f1954
Fix undescriptive normalize function name
ryanaoleary 0a150b8
Update tests and add unhappy path coverage
ryanaoleary 331e8cd
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary d21d001
Fix test_schema.py for validate bundle_label_selector
ryanaoleary bc26060
Import match label selector logic from C++ instead
ryanaoleary 523de76
Merge branch 'master' into add-label-selector-serve-option
ryanaoleary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.