Skip to content

Conversation

@pseudo-rnd-thoughts
Copy link
Member

Description

RLlib's rayci.yml file and the BUILD.bazel file are disconnected such that there are old tags in the BUILD not the rayci and vice-versa.
This PR attempts to clean up both files without modifying what tests are or aren't run currently

Mark Towers added 5 commits December 11, 2025 15:20
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts added rllib RLlib related issues build labels Dec 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a much-needed cleanup of the test tags in rllib/BUILD.bazel and the CI configuration in .buildkite/rllib.rayci.yml. The changes significantly improve maintainability by simplifying the tagging scheme and making the CI steps more explicit and organized. The large-scale removal of unused and confusing tags in BUILD.bazel is a great improvement. My review identified one potential issue in the CI configuration that might unintentionally alter the set of tests being run, contrary to the PR's stated goal. A suggestion has been provided to address this. Overall, this is a valuable cleanup effort.

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title [rllib] Cleanup build bazel [rllib] Cleanup BUILD.bazel and rllib.rayci.yml Dec 11, 2025
Signed-off-by: Mark Towers <mark@anyscale.com>
@kamil-kaczmarek
Copy link
Contributor

kamil-kaczmarek commented Dec 17, 2025

@simonsays1980 Do you plan to use learning_tests_with_ray_data tag in BUILD.bazel? I don't see any tests with this tag added, yet we have it in rllib.rayci.yml. If you don't use it we will remove it to simplify.

I see that ray_data tag is in use, maybe we can just remove learning_tests_with_ray_data, as it looks like it's duplicate?

cc: @pseudo-rnd-thoughts

Copy link
Contributor

@kamil-kaczmarek kamil-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments.

Signed-off-by: Mark Towers <mark@anyscale.com>
@simonsays1980
Copy link
Contributor

learning_tests_with_ray_data

@kamil-kaczmarek (cc. @pseudo-rnd-thoughts ) I have never personally used this tag. So I think its safe to remove it.

Signed-off-by: Mark Towers <mark@anyscale.com>
# Conflicts:
#	rllib/BUILD.bazel
Mark Towers added 2 commits December 30, 2025 16:40
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts added the go add ONLY when ready to merge, run all tests label Dec 31, 2025
Mark Towers added 2 commits January 12, 2026 15:04
@kamil-kaczmarek
Copy link
Contributor

Notably this clean up removes following tags from BUILD.bazel:

  • learning_tests_discrete
  • learning_tests_continuous
  • learning_tests_pytorch_use_all_core
  • ray_data
  • old_api_stack
  • learning_tests_with_ray_data

Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Copy link
Contributor

@kamil-kaczmarek kamil-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

@ArturNiederfahrenhorst ArturNiederfahrenhorst merged commit 0da3533 into ray-project:master Jan 13, 2026
6 checks passed
rushikeshadhav pushed a commit to rushikeshadhav/ray that referenced this pull request Jan 14, 2026
## Description
RLlib's rayci.yml
[file](https://github.com/ray-project/ray/blob/master/.buildkite/rllib.rayci.yml)
and the BUILD.bazel
[file](https://github.com/ray-project/ray/blob/master/rllib/BUILD.bazel)
are disconnected such that there are old tags in the BUILD not the rayci
and vice-versa.
This PR attempts to clean up both files without modifying what tests are
or aren't run currently

---------

Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Co-authored-by: Mark Towers <mark@anyscale.com>
Co-authored-by: Kamil Kaczmarek <kamil@anyscale.com>
jeffery4011 pushed a commit to jeffery4011/ray that referenced this pull request Jan 20, 2026
## Description
RLlib's rayci.yml
[file](https://github.com/ray-project/ray/blob/master/.buildkite/rllib.rayci.yml)
and the BUILD.bazel
[file](https://github.com/ray-project/ray/blob/master/rllib/BUILD.bazel)
are disconnected such that there are old tags in the BUILD not the rayci
and vice-versa.
This PR attempts to clean up both files without modifying what tests are
or aren't run currently

---------

Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
Co-authored-by: Mark Towers <mark@anyscale.com>
Co-authored-by: Kamil Kaczmarek <kamil@anyscale.com>
Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build go add ONLY when ready to merge, run all tests rllib RLlib related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants