Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rayciversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.21.0
0.23.0
12 changes: 12 additions & 0 deletions ci/pipeline/test_rules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
# file # File to match
# dir/*.py # Pattern to match, using fnmatch, matches dir/a.py dir/dir/b.py or dir/.py
# @ tag1 tag2 tag3 # Tags to emit for a rule. A rule without tags is a skipping rule.
# \fallthrough # Tags are always included, matching continues to next rule
# \default # Rule matches any file (catch-all)
#
# ; # Semicolon to separate rules

Expand All @@ -20,6 +22,10 @@
! linux_wheels macos_wheels docker doc python_dependencies tools
! release_tests spark_on_ray

\fallthrough
@ always lint
Comment on lines +25 to +26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading this now, this feels a bit unnatural to read.

I feel that it should be something like:

*  # matching anything
@ always lint
\fallthrough # can only be right before a `;` line.
;

then this file is still going through a roughly speaking sequential logic flow

otherwise, maybe it is still more natural to write:

\always
@ always lint
;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the change to update to the first proposal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;

python/ray/air/
@ ml train tune data linux_wheels
;
Expand Down Expand Up @@ -257,3 +263,9 @@ setup_hooks.sh
.fossa.yml
# pass
;

\default
@ ml tune train data serve
@ core_cpp cpp java python doc
@ linux_wheels macos_wheels dashboard tools release_tests
;