-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add wanda anyscale image builds for release tests #59937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrew-anyscale
wants to merge
1
commit into
andrew/revup/master/ray-image
Choose a base branch
from
andrew/revup/master/anyscale-image
base: andrew/revup/master/ray-image
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Ray Anyscale CPU Image (for release tests) | ||
| # Installs ray wheel into the CPU base-extra-testdeps image | ||
| # | ||
| # This produces the anyscale test image for CPU-only release tests. | ||
| # Unlike the regular ray image, this uses base-extra-testdeps which | ||
| # includes additional test dependencies. | ||
| # | ||
| name: "ray-anyscale-py$PYTHON_VERSION-cpu$ARCH_SUFFIX" | ||
| disable_caching: true | ||
| froms: | ||
| - "cr.ray.io/rayproject/ray-py$PYTHON_VERSION-cpu-base-extra-testdeps" # CPU base with test deps | ||
| - "cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX" # Ray wheel | ||
| dockerfile: ci/docker/ray-image.Dockerfile | ||
| srcs: | ||
| - python/requirements_compiled.txt | ||
| build_args: | ||
| - PYTHON_VERSION | ||
| - ARCH_SUFFIX | ||
| - BASE_IMAGE=cr.ray.io/rayproject/ray-py$PYTHON_VERSION-cpu-base-extra-testdeps | ||
| - RAY_WHEEL_IMAGE=cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Ray Anyscale CUDA Image (for release tests) | ||
| # Installs ray wheel into the CUDA base-extra-testdeps image | ||
| # | ||
| # This produces the anyscale test image for GPU release tests. | ||
| # Unlike the regular ray image, this uses base-extra-testdeps which | ||
| # includes additional test dependencies. | ||
| # | ||
| name: "ray-anyscale-py$PYTHON_VERSION-cu$CUDA_VERSION$ARCH_SUFFIX" | ||
| disable_caching: true | ||
| froms: | ||
| - "cr.ray.io/rayproject/ray-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps" # CUDA base with test deps | ||
| - "cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX" # Ray wheel | ||
| dockerfile: ci/docker/ray-image.Dockerfile | ||
| srcs: | ||
| - python/requirements_compiled.txt | ||
| build_args: | ||
| - PYTHON_VERSION | ||
| - CUDA_VERSION | ||
| - ARCH_SUFFIX | ||
| - BASE_IMAGE=cr.ray.io/rayproject/ray-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps | ||
| - RAY_WHEEL_IMAGE=cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Ray-LLM Anyscale CUDA Image (for release tests) | ||
| # Installs ray wheel into the ray-llm CUDA base-extra-testdeps image | ||
| # | ||
| # This produces the anyscale test image for ray-llm GPU release tests. | ||
| # Uses ray-llm base with extra test dependencies. | ||
| # | ||
| name: "ray-llm-anyscale-py$PYTHON_VERSION-cu$CUDA_VERSION$ARCH_SUFFIX" | ||
| disable_caching: true | ||
| froms: | ||
| - "cr.ray.io/rayproject/ray-llm-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps" # ray-llm base with test deps | ||
| - "cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX" # Ray wheel | ||
| dockerfile: ci/docker/ray-image.Dockerfile | ||
| srcs: | ||
| - python/requirements_compiled.txt | ||
| build_args: | ||
| - PYTHON_VERSION | ||
| - CUDA_VERSION | ||
| - ARCH_SUFFIX | ||
| - BASE_IMAGE=cr.ray.io/rayproject/ray-llm-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps | ||
| - RAY_WHEEL_IMAGE=cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Ray-ML Anyscale CUDA Image (for release tests) | ||
| # Installs ray wheel into the ray-ml CUDA base-extra-testdeps image | ||
| # | ||
| # This produces the anyscale test image for ray-ml GPU release tests. | ||
| # Uses ray-ml base with extra test dependencies. | ||
| # | ||
| name: "ray-ml-anyscale-py$PYTHON_VERSION-cu$CUDA_VERSION$ARCH_SUFFIX" | ||
| disable_caching: true | ||
| froms: | ||
| - "cr.ray.io/rayproject/ray-ml-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps" # ray-ml base with test deps | ||
| - "cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX" # Ray wheel | ||
| dockerfile: ci/docker/ray-image.Dockerfile | ||
| srcs: | ||
| - python/requirements_compiled.txt | ||
| build_args: | ||
| - PYTHON_VERSION | ||
| - CUDA_VERSION | ||
| - ARCH_SUFFIX | ||
| - BASE_IMAGE=cr.ray.io/rayproject/ray-ml-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra-testdeps | ||
| - RAY_WHEEL_IMAGE=cr.ray.io/rayproject/ray-wheel-py$PYTHON_VERSION$ARCH_SUFFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These authentication commands are duplicated across the
anyscalebuild,anyscalellmbuild, andanyscalemlbuildpush jobs. To improve maintainability and reduce redundancy, consider using YAML anchors and aliases to define these commands once and reuse them in each job. This will make future updates to the authentication process much easier.