-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add wanda builds for aarch64 architecture #59938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrew-anyscale
wants to merge
4
commits into
andrew/revup/master/anyscale-image
Choose a base branch
from
andrew/revup/master/ray-aarch64
base: andrew/revup/master/anyscale-image
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
32347fa
Migrate wheel builds to wanda (x86_64)
andrew-anyscale 29cf5ab
Add wanda ray image builds for Docker Hub
andrew-anyscale 4a143b7
Add wanda anyscale image builds for release tests
andrew-anyscale 7e7a73e
Add wanda builds for aarch64 architecture
andrew-anyscale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous implementation for building
ray-extraimages (lines 154-179 in the original file) included an--uploadflag, which resulted in the images being pushed. The new wanda-based build steps forray-extraonly build and cache the images in ECR, but they are not pushed to a public registry like Docker Hub. This appears to be a regression. To restore the original behavior, push steps forray-extraimages should be added, similar to the ones implemented for therayimages (e.g., lines 363-385).