-
Notifications
You must be signed in to change notification settings - Fork 7.1k
wanda python-agnostic ray-cpp wheel (py3-none tag)(x86_64) #59969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #!/bin/bash | ||
| # Build Python-agnostic ray-cpp wheel. | ||
| # | ||
| # The ray-cpp wheel contains only C++ headers, libraries, and executables | ||
| # with no Python version-specific content. This script builds a single wheel | ||
| # tagged py3-none-manylinux2014_* that works with any Python 3 version. | ||
| # | ||
| # Usage: ./ci/build/build-cpp-wheel.sh | ||
| # | ||
| # Environment variables: | ||
| # BUILDKITE_COMMIT - Git commit SHA for ray.__commit__ (required) | ||
|
|
||
| set -exuo pipefail | ||
|
|
||
| TRAVIS_COMMIT="${TRAVIS_COMMIT:-$BUILDKITE_COMMIT}" | ||
|
|
||
| # Use any Python 3 to run setuptools (wheel content is Python-agnostic) | ||
| PYTHON="cp310-cp310" | ||
|
|
||
| mkdir -p .whl | ||
| cd python | ||
|
|
||
| /opt/python/"${PYTHON}"/bin/pip install -q cython==3.0.12 setuptools==80.9.0 | ||
|
|
||
| # Set the commit SHA in _version.py | ||
| if [[ -n "$TRAVIS_COMMIT" ]]; then | ||
| sed -i.bak "s/{{RAY_COMMIT_SHA}}/$TRAVIS_COMMIT/g" ray/_version.py && rm ray/_version.py.bak | ||
| else | ||
| echo "TRAVIS_COMMIT variable not set - required to populate ray.__commit__." | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Determine platform tag based on architecture | ||
| ARCH=$(uname -m) | ||
| if [[ "$ARCH" == "x86_64" ]]; then | ||
| PLAT_NAME="manylinux2014_x86_64" | ||
| elif [[ "$ARCH" == "aarch64" ]]; then | ||
| PLAT_NAME="manylinux2014_aarch64" | ||
| else | ||
| echo "ERROR: Unsupported architecture: $ARCH" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Building ray-cpp wheel (Python-agnostic, platform: $PLAT_NAME)..." | ||
|
|
||
| # Build wheel with py3-none tag (Python version-agnostic) | ||
| # SKIP_BAZEL_BUILD=1 because artifacts are pre-built from wanda cache | ||
| PATH="/opt/python/${PYTHON}/bin:$PATH" \ | ||
| SKIP_BAZEL_BUILD=1 RAY_INSTALL_JAVA=0 RAY_INSTALL_CPP=1 \ | ||
| "/opt/python/${PYTHON}/bin/python" setup.py bdist_wheel \ | ||
| --python-tag py3 \ | ||
| --plat-name "$PLAT_NAME" | ||
|
|
||
| mv dist/*.whl ../.whl/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # syntax=docker/dockerfile:1.3-labs | ||
| # | ||
| # Ray C++ Core Artifacts Builder | ||
| # ============================== | ||
| # Builds ray_cpp_pkg.zip containing C++ headers, libraries, and examples. | ||
| # | ||
| ARG ARCH_SUFFIX= | ||
| ARG HOSTTYPE=x86_64 | ||
| ARG MANYLINUX_VERSION | ||
| FROM rayproject/manylinux2014:${MANYLINUX_VERSION}-jdk-${HOSTTYPE} AS builder | ||
|
|
||
| ARG PYTHON_VERSION=3.10 | ||
| ARG BUILDKITE_BAZEL_CACHE_URL | ||
| ARG BUILDKITE_CACHE_READONLY | ||
| ARG HOSTTYPE | ||
|
|
||
| WORKDIR /home/forge/ray | ||
|
|
||
| COPY . . | ||
|
|
||
| # Mounting cache dir for faster local rebuilds (architecture-specific to avoid toolchain conflicts) | ||
| RUN --mount=type=cache,target=/home/forge/.cache,uid=2000,gid=100,id=bazel-cache-${HOSTTYPE}-${PYTHON_VERSION} \ | ||
| <<'EOF' | ||
| #!/bin/bash | ||
| set -euo pipefail | ||
|
|
||
| PY_CODE="${PYTHON_VERSION//./}" | ||
| PY_BIN="cp${PY_CODE}-cp${PY_CODE}" | ||
| export RAY_BUILD_ENV="manylinux_py${PY_BIN}" | ||
|
|
||
| sudo ln -sf "/opt/python/${PY_BIN}/bin/python3" /usr/local/bin/python3 | ||
| sudo ln -sf /usr/local/bin/python3 /usr/local/bin/python | ||
|
|
||
| if [[ "${BUILDKITE_CACHE_READONLY:-}" == "true" ]]; then | ||
| echo "build --remote_upload_local_results=false" >> "$HOME/.bazelrc" | ||
| fi | ||
|
|
||
| echo "build --repository_cache=/home/forge/.cache/bazel-repo" >> "$HOME/.bazelrc" | ||
|
|
||
| bazelisk build --config=ci //cpp:ray_cpp_pkg_zip | ||
|
|
||
| cp bazel-bin/cpp/ray_cpp_pkg.zip /home/forge/ray_cpp_pkg.zip | ||
|
|
||
| EOF | ||
|
|
||
| FROM scratch | ||
|
|
||
| COPY --from=builder /home/forge/ray_cpp_pkg.zip / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: "ray-cpp-core-py$PYTHON_VERSION$ARCH_SUFFIX" | ||
| froms: ["rayproject/manylinux2014:$MANYLINUX_VERSION-jdk-$HOSTTYPE"] | ||
| dockerfile: ci/docker/ray-cpp-core.Dockerfile | ||
| srcs: | ||
| - .bazelversion | ||
| - .bazelrc | ||
| - WORKSPACE | ||
| - BUILD.bazel | ||
| - bazel/ | ||
| - thirdparty/ | ||
| - src/ | ||
| - cpp/ | ||
| - python/ray/__init__.py | ||
| - python/ray/_raylet.pxd | ||
| - python/ray/_raylet.pyi | ||
| - python/ray/_raylet.pyx | ||
| - python/ray/includes/ | ||
| - java/BUILD.bazel | ||
| - java/dependencies.bzl | ||
| - release/BUILD.bazel | ||
| - release/requirements.txt | ||
| - release/requirements_py310.txt | ||
aslonnie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| build_args: | ||
| - PYTHON_VERSION | ||
| - ARCH_SUFFIX | ||
| - HOSTTYPE | ||
| - MANYLINUX_VERSION | ||
| - BUILDKITE_BAZEL_CACHE_URL | ||
| build_hint_args: | ||
| - BUILDKITE_CACHE_READONLY | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # syntax=docker/dockerfile:1.3-labs | ||
| # | ||
| # Ray C++ Wheel Builder | ||
| # ===================== | ||
| # Builds manylinux2014-compatible ray-cpp wheel using pre-built C++ artifacts from wanda cache. | ||
| # | ||
| # This is a minimal Dockerfile for ray-cpp wheel builds only. | ||
| # It copies only the files needed for the cpp wheel, reducing build context size. | ||
|
|
||
| ARG RAY_CORE_IMAGE | ||
| ARG RAY_CPP_CORE_IMAGE | ||
| ARG RAY_JAVA_IMAGE | ||
| ARG RAY_DASHBOARD_IMAGE | ||
| ARG MANYLINUX_VERSION | ||
| ARG HOSTTYPE | ||
|
|
||
| FROM ${RAY_CORE_IMAGE} AS ray-core | ||
| FROM ${RAY_CPP_CORE_IMAGE} AS ray-cpp-core | ||
| FROM ${RAY_JAVA_IMAGE} AS ray-java | ||
| FROM ${RAY_DASHBOARD_IMAGE} AS ray-dashboard | ||
|
|
||
| # Main build stage - manylinux2014 provides GLIBC 2.17 | ||
| FROM rayproject/manylinux2014:${MANYLINUX_VERSION}-jdk-${HOSTTYPE} AS builder | ||
|
|
||
| ARG BUILDKITE_COMMIT | ||
|
|
||
| WORKDIR /home/forge/ray | ||
|
|
||
| # Copy artifacts from all stages | ||
| COPY --from=ray-core /ray_pkg.zip /tmp/ | ||
| COPY --from=ray-core /ray_py_proto.zip /tmp/ | ||
| COPY --from=ray-java /ray_java_pkg.zip /tmp/ | ||
| COPY --from=ray-dashboard /dashboard.tar.gz /tmp/ | ||
|
|
||
| # Minimal source files needed for cpp wheel build | ||
| COPY --chown=forge ci/build/build-ray-cpp-wheel.sh ci/build/ | ||
| COPY --chown=forge README.rst pyproject.toml ./ | ||
| COPY --chown=forge python/setup.py python/ | ||
| COPY --chown=forge python/LICENSE.txt python/ | ||
| COPY --chown=forge python/MANIFEST.in python/ | ||
| COPY --chown=forge python/ray/_version.py python/ray/ | ||
|
|
||
| USER forge | ||
| ENV BUILDKITE_COMMIT=${BUILDKITE_COMMIT:-unknown} | ||
| RUN --mount=from=ray-cpp-core,source=/,target=/ray-cpp-core,ro \ | ||
| <<'EOF' | ||
| #!/bin/bash | ||
| set -euo pipefail | ||
|
|
||
| # Clean extraction dirs to avoid stale leftovers | ||
| rm -rf /tmp/ray_pkg /tmp/ray_java_pkg /tmp/ray_cpp_pkg | ||
| mkdir -p /tmp/ray_pkg /tmp/ray_java_pkg /tmp/ray_cpp_pkg | ||
|
|
||
| # Unpack pre-built artifacts | ||
| unzip -o /tmp/ray_pkg.zip -d /tmp/ray_pkg | ||
| unzip -o /tmp/ray_py_proto.zip -d python/ | ||
| unzip -o /tmp/ray_java_pkg.zip -d /tmp/ray_java_pkg | ||
| mkdir -p python/ray/dashboard/client/build | ||
| tar -xzf /tmp/dashboard.tar.gz -C python/ray/dashboard/client/build/ | ||
|
|
||
| # C++ core artifacts | ||
| cp -r /tmp/ray_pkg/ray/* python/ray/ | ||
|
|
||
| # Java JARs | ||
| cp -r /tmp/ray_java_pkg/ray/* python/ray/ | ||
|
|
||
| # C++ API artifacts (headers, libs, examples) | ||
| unzip -o /ray-cpp-core/ray_cpp_pkg.zip -d /tmp/ray_cpp_pkg | ||
| cp -r /tmp/ray_cpp_pkg/ray/cpp python/ray/ | ||
|
|
||
| # Build Python-agnostic cpp wheel | ||
| ./ci/build/build-ray-cpp-wheel.sh | ||
|
|
||
| # Sanity check: ensure wheels exist | ||
| if [[ ! -d .whl ]]; then | ||
| echo "ERROR: .whl directory not created" | ||
| exit 1 | ||
| fi | ||
| wheels=($(find .whl -maxdepth 1 -name '*.whl')) | ||
| if (( ${#wheels[@]} == 0 )); then | ||
| echo "ERROR: No wheels produced in .whl/" | ||
| ls -la .whl | ||
| exit 1 | ||
| fi | ||
|
|
||
| EOF | ||
|
|
||
| FROM scratch | ||
| COPY --from=builder /home/forge/ray/.whl/*.whl / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Python-agnostic ray-cpp wheel. | ||
| # Uses upstream images from one Python version but produces a py3-none wheel | ||
| # that works with any Python 3. PYTHON_VERSION is set at buildkite level. | ||
| name: "ray-cpp-wheel$ARCH_SUFFIX" | ||
| froms: | ||
| - "rayproject/manylinux2014:$MANYLINUX_VERSION-jdk-$HOSTTYPE" | ||
| - "cr.ray.io/rayproject/ray-core-py$PYTHON_VERSION$ARCH_SUFFIX" # C++ binaries (ray_pkg.zip) | ||
| - "cr.ray.io/rayproject/ray-cpp-core-py$PYTHON_VERSION$ARCH_SUFFIX" # C++ headers/libs (ray_cpp_pkg.zip) | ||
| - "cr.ray.io/rayproject/ray-java-build$ARCH_SUFFIX" # Java JARs | ||
| - "cr.ray.io/rayproject/ray-dashboard" # Dashboard | ||
| dockerfile: ci/docker/ray-cpp-wheel.Dockerfile | ||
| srcs: | ||
| - pyproject.toml | ||
| - README.rst | ||
| - ci/build/build-ray-cpp-wheel.sh | ||
| - python/setup.py | ||
| - python/LICENSE.txt | ||
| - python/MANIFEST.in | ||
| - python/ray/_version.py | ||
| build_args: | ||
| - MANYLINUX_VERSION | ||
| - HOSTTYPE | ||
| - BUILDKITE_COMMIT | ||
| - ARCH_SUFFIX | ||
| - RAY_CORE_IMAGE=cr.ray.io/rayproject/ray-core-py$PYTHON_VERSION$ARCH_SUFFIX | ||
| - RAY_CPP_CORE_IMAGE=cr.ray.io/rayproject/ray-cpp-core-py$PYTHON_VERSION$ARCH_SUFFIX | ||
| - RAY_JAVA_IMAGE=cr.ray.io/rayproject/ray-java-build$ARCH_SUFFIX | ||
| - RAY_DASHBOARD_IMAGE=cr.ray.io/rayproject/ray-dashboard |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.