[docs] [serve] [fix] fix error 404 asynchronous inference example #60071
+29
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aydin Abiar <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a 404 error in the documentation for the asynchronous inference example. The changes involve updating the link in doc/source/serve/examples.yml to point to the asynchronous-inference.ipynb notebook, and removing this notebook from the exclude_patterns in doc/source/conf.py so it gets built by Sphinx. This aligns with the stated goal of using the notebook as the single source of truth. The changes are accurate and effectively fix the issue.
added 2 commits
January 12, 2026 16:03
Signed-off-by: Aydin Abiar <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
doc/source/serve/tutorials/asynchronous-inference/content/asynchronous-inference.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: Aydin Abiar <[email protected]>
harshit-anyscale
approved these changes
Jan 13, 2026
ray-gardener
bot
added
serve
Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed #59917 but it didn't fix it
The notebook should be the single source of truth since it’s what's tested and validated, so we should link to it rather than the README.md. The README.md is generated from the notebook (jupyter nbconvert) and exists only for display in the console when converting the example into an Anyscale template