Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Extension: TeamGantt #2896

Merged
merged 14 commits into from
Sep 20, 2022
Merged

New Extension: TeamGantt #2896

merged 14 commits into from
Sep 20, 2022

Conversation

knownasilya
Copy link
Contributor

@knownasilya knownasilya commented Sep 15, 2022

Description

First version of interacting with tasks on TeamGantt project management. There are two commands, My Tasks and Search Tasks.

Screencast

raycast-tg2

Checklist

@knownasilya knownasilya changed the title feat: addteamgantt extension feat: add teamgantt extension Sep 15, 2022
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Sep 15, 2022
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

@knownasilya knownasilya marked this pull request as ready for review September 15, 2022 04:02
@knownasilya
Copy link
Contributor Author

This is ready for review 😄

@knownasilya knownasilya changed the title feat: add teamgantt extension New Extension: TeamGantt Sep 15, 2022
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I tested your extension and have some feedback and suggestions for you 🙂

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Sep 19, 2022
@knownasilya
Copy link
Contributor Author

@pernielsentikaer thanks for the feedback. Learned a few things along the way. Should be ready for re-review.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for the update 🔥

I added a few more things to correct, I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

accessoryTitle={keywords.join(', ')}
accessoryIcon={task.is_starred ? Icon.Star : undefined}
actions={
<ActionPanel title={`'${task.name}' actions`}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might just go with Actions since the name can be pretty long


<ActionPanel.Section title="TimeSheets">
<Action
title="Punch Out"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing icon

onAction={() => timeBlock && punchOut(timeBlock.id, undefined, idToken)}
/>

<Action title="Punch In" onAction={() => punchIn(task.id, idToken)} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing icon


return (
<List
navigationTitle="Tasks"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the navigationTitle in the root command - it will be automatically set to the command name. Use navigationTitle only in nested screens to provide additional context.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 66136f6 into raycast:main Sep 20, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/knownasilya/teamgantt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants