Fix clipboard crash and add extra methods #23
Conversation
rlImGui/rlImGui.cs
Outdated
| /// <summary> | ||
| /// Set the filename of the INI file that ImGui uses to store the window configuration. | ||
| /// It is set to "imgui.ini" by default. | ||
| /// | ||
| /// Call this after rlImGui.Setup. | ||
| /// </summary> | ||
| /// <param name="iniFilename">The file path to store the ini file.</param> | ||
| public static void SetIniFilename(string iniFilename) | ||
| { | ||
| if (iniFilenameAlloc != 0) | ||
| Marshal.FreeHGlobal(iniFilenameAlloc); | ||
|
|
||
| byte[] nameBytes = System.Text.Encoding.ASCII.GetBytes(iniFilename + "\0"); | ||
| iniFilenameAlloc = Marshal.AllocHGlobal(nameBytes.Length); | ||
| Marshal.Copy(nameBytes, 0, iniFilenameAlloc, nameBytes.Length); | ||
|
|
||
| unsafe | ||
| { | ||
| ImGui.GetIO().NativePtr->IniFilename = (byte*) iniFilenameAlloc; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure I like this being internal to rlImGui. it's not raylib specific and doesn't really have anything to do with this backend. This code would be used on any C# imgui system.
I'd prefer to keep rlImGui just for things that deal with raylib and ImGui, not random imgui utilities, they should go into a separate and optional library.
| private static GetClipTextCallback getClipCallback = null!; | ||
| private static SetClipTextCallback setClipCallback = null!; | ||
|
|
There was a problem hiding this comment.
Is this all that's needed for the crash fix?
There was a problem hiding this comment.
Yes. I did make a test with the old code, my code, and a GC button. On the old code, the clipboard would work fine until I pressed the GC button, at which point copying or pasting from/to a text field would cause a hard crash on the program. With my new code, the clipboard still worked fine even after pressing the GC button.
rlImGui/rlImGui.cs
Outdated
| /// <summary> | ||
| /// Draw a texture as an image in an ImGui Context | ||
| /// Uses the current ImGui Cursor position and the full texture size. | ||
| /// </summary> | ||
| /// <param name="image">The raylib texture to draw</param> | ||
| /// <param name="tintColor">The color to tint the image with</param> | ||
| public static void Image(Texture2D image, Color tintColor) | ||
| { | ||
| ImGui.Image( | ||
| new IntPtr(image.Id), | ||
| new Vector2(image.Width, image.Height), | ||
| Vector2.Zero, Vector2.One, | ||
| new Vector4(tintColor.R / 255f, tintColor.G / 255f, tintColor.B / 255f, tintColor.A / 255f) | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I prefer to keep rlImGui-cs feature compatible with the C++ version.
I'm not against having a tint version, but it should not duplicate code like this.
The tint should be an optional argument on the existing functions, or the non-tint versions should call the tint versions with a default tint. This feature would also need to be added to the C++ version for parity.
There was a problem hiding this comment.
Alright, I have fixed the code duplication problem, and I'll begin working on a PR to the C++ version with the same features.
This pull request fixes a potential crash when ImGui interacts with the user's clipboard caused by the clipboard delegates being garbage-collected. It also adds extra methods that may be useful, namely one for setting the ini filename and several for drawing Image and ImageButtons with a tint and/or custom source UVs.