Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of
par_medianand other variants for n-th element selection.The algorithm works as follows: 1) sample a subset of roughly
sqrt(len)elements, 2) sort that sample, 3) pick lower and upper bounds close to thek/lenqunatile within the sample, 4) collect all elements between these bounds from the input array, 5) if the k-th element lies within the bounds or equals one of the bounds, return it. Note, that this can fail if the initial sample or bound selection was "bad". In that case we currently fall back to a sequential call toselect_nth_unstable().As opposed to what I wrote in #1254, this implementation now seems to perform well even for non-uniform low-cardinality data (due to the counting of elements that equal either of the bounds).
Addresses #1254.