[GLFW backend] WindowSizeCallback() should not handle DPI scale. GLFW already do that
#4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aged by GLFW If `FLAG_WINDOW_HIGHDPI` is set, `InitPlatform()` will aks GLFW to handle resize window content area based on the monitor content scale using : ` glfwWindowHint(GLFW_SCALE_TO_MONITOR, GLFW_TRUE); ` So `WindowSizeCallback()` does not have to handle it a second time.
SuperUserNameMan
changed the title
WindowSizeCallback() should not handle DPI scale. GLFW already do thatWindowSizeCallback() should not handle DPI scale. GLFW already do that
|
Works good on Windows |
|
@SuperUserNameMan @veins1 Looks good to me, thanks for the review! |
|
This PR improved the issue, but it was not the REAL solution. I think i've found where the REAL problem was from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #3972 on my Linux desktop.
Awaiting confirmation on Windows platform.
MACOS not impacted.
If
FLAG_WINDOW_HIGHDPIis set,InitPlatform()will ask GLFW to handle the resizing of window content area based on the monitor content scale using :glfwWindowHint(GLFW_SCALE_TO_MONITOR, GLFW_TRUE);So
WindowSizeCallback()should not try to handle DPI rescale a second time.