Conversation
This commit works in progress
- mainly function base modules are modified
this modification is derived from the cython 3.0 compile error.
…`INFINITY` in `libc.math` .
…re/cython3 # Conflicts: # pyproject.toml # setup.py
There was a problem hiding this comment.
This is an out-of-scope suggestion for this PR, but what about using dynamic versioning tools like setuptools-scm or hatch-vsc?
There was a problem hiding this comment.
We use setuptools-scm at Luffy AI, it works well. I'll look into integrating it after this PR. Also planning to use cibuildwheel to build releases.
…a longstanding typo.
|
I believe all the necessary changes (plus some API fixing) have been completed. I've temporarily enabled the legacy noexcept behaviour for two reasons:
This does mean you will see a huge number of deprecation warnings which I can't seem to disable. Please ignore them for now. |
|
Performed some quick testing. Running without |
|
We have some positive progress on pycharm addressing their syntax highlighting: https://youtrack.jetbrains.com/issue/PY-59249/Cython-3-except-noexcept-legal-syntax-red-lined I'm tempted to move forward with the merge this evening and file an issue to rework the code to address the deprecation warning once the pycharm fix is in the wild. |
|
Have decided to merge this and raised an issue to address the deprecation later. |
# Conflicts: # raysect/core/math/sampler/meson.build # raysect/optical/observer/imaging/meson.build # raysect/optical/observer/nonimaging/meson.build
2 participants
This PR builds on the work of @munechika-koyo in #426.
Raysect is finally moving to Cython 3.1!