Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow trial on default plan of billing account #739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kushsharma
Copy link
Member

@kushsharma kushsharma commented Aug 24, 2024

When the org is created, if a default billing account of customer is registered to billing provider and a default plan is configured with trial days, subscription will start within trial days. By default, after trial expires, it will continue the subscription if payment method is setup. If no payment is setup, it will auto cancel. To cancel the plan after trial even after payment method is setup in a customer account, set billing.customer.default_plan_cancel_after_trial as true.

Copy link

vercel bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:17pm

@coveralls
Copy link

coveralls commented Aug 24, 2024

Pull Request Test Coverage Report for Build 10599494265

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 9.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
billing/checkout/service.go 0 5 0.0%
core/event/service.go 0 8 0.0%
Totals Coverage Status
Change from base Build 10590915744: -0.001%
Covered Lines: 10463
Relevant Lines: 110224

💛 - Coveralls

@ravisuhag
Copy link
Member

@kushsharma @anujk14 more context on this please ?

@anujk14
Copy link
Contributor

anujk14 commented Aug 26, 2024

@kushsharma @anujk14 more context on this please ?

@ravisuhag This will allow us to provide trials by default to users. For example, if we mark enterprise plan as the default one, and it has any trial days set, the user will be put on a free trial by default.

This is with reference to the decision doc that was shared earlier with us where we wanted to provide the enterprise trial by default to customers.

@kushsharma kushsharma marked this pull request as draft August 28, 2024 15:09
When the org is created, if a default billing account of customer
is registered to billing provider and a default plan is configured with
trial days, subscription will start within trial days.
By default, after trial expires, it will continue the subscription
if payment method is setup. If no payment is setup, it will auto cancel.
To cancel the plan after trial even after payment method is setup
in a customer account, set `billing.customer.default_plan_cancel_after_trial`
as true.

Signed-off-by: Kush Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants