[breaking change: fix #550] moves away from global variables #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- going forward, there are a couple of ways to access state from
the settings callbacks
- `settings` functions should always take in `widget` and `now` as the
arguments. so the signature is `settings = function(widget, now)`
- use `foo.widget` and `foo.now` to access the awesome widget and
current state (respectively) of `foo` widget
- weather has been done in lcpz#549
- sysload's state is now in a `now` table. access the 1, 5 and 15 min
load averages via `now[1]`, `now[5]`, and `now[15]`
- the bat and contrib/tp_smapi widgets have NOT been migrated as i do
not have a laptop to verify behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settingsfunctions should always take inwidgetandnowas the arguments. so the signature issettings = function(widget, now)foo.widgetandfoo.nowto access the awesome widget and current state (respectively) offoowidgetnowtable. access the 1, 5 and 15 min load averages vianow[1],now[5], andnow[15]