-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented RPC Manager for RPC calls #1260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: introduced block monitor to keep track of blocks * refactor: removed global variables used in logger and added blockMonitor as a field * refactor: used refactored logger module * fix: fixed logger global instance * refactor: exported logrus instance field from logger struct * refactor: fixed tests * refactor: removed unwanted return variables in tests * refactor: added log for current best endpoint URL after every refresh * fix: added endpoint validation while switching endpoints * fix: added switched returned type while switching endpoints and removed staleBlockCallback field
Yashk767
commented
Dec 3, 2024
Rename |
Done in 5631ae4 @ashish10677 |
ashish10677
reviewed
Dec 11, 2024
ashish10677
approved these changes
Dec 11, 2024
rajkharvar
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented an RPC Manager which handles RPC selection at the start selecting the best RPC out of the available endpoints. Proceeding further it handles the switching and refreshing of RPC endpoints in a sorted order of there performance.
Also introduces a
blockMonitor
inblock
module which is resposnsible for providing block number to the logs and also check for stale blocks from the current best RPC endpoint.This is implemented in #126.
Introduced a
importEndpoints
command which imports the list of endpoints provided incore/endpoints.go
to file$HOME/.rzr/endpoints
.Fixes https://linear.app/interstellar-research/issue/RAZ-1026
How Has This Been Tested?
Ran a staker with vote command on testnet by providing multiple active and inactive RPCs.
Analysed the refresh periods, switching when RPC is down, and when RPC endpoints are not imported.