fix(DatePicker): Arrow alignment #2292
Open
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-parihar
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
🦋 Changeset detectedLatest commit: 14f959f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ef5a22:
|
anuraghazra
reviewed
Nov 8, 2024
| <ArrowRightIcon | ||
| size="medium" | ||
| // marginTop={ |
anuraghazra
reviewed
Nov 8, 2024
.changeset/neat-spies-add.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@razorpay/blade': major | |||
There was a problem hiding this comment.
Suggested change
| '@razorpay/blade': major | |
| '@razorpay/blade': patch |
anuraghazra
reviewed
Nov 8, 2024
.changeset/neat-spies-add.md
Outdated
| '@razorpay/blade': major | ||
| --- | ||
|
|
||
| "DatePicker range icon's margin top fixed" |
There was a problem hiding this comment.
Suggested change
| "DatePicker range icon's margin top fixed" | |
| fix(blade): DatePicker range icon's alignment |
anuraghazra
previously approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tried fixing the icon position in date range picker when label is absent.
Changes
label-heightasmargin-topto iconBefore
After
Additional Information
Fixes #2256