Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hideClearButton Prop to SearchInput Component #2433

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

yadavshubham01
Copy link

This pull request introduces a new prop, hideClearButton, to the SearchInput component. This prop allows users to control the visibility of the clear button in the input field, enhancing the component's flexibility for various use cases.

Changes Made:

  1. Added hideClearButton Prop: This boolean prop determines whether the clear button should be displayed when there is text in the input field.
  2. Updated Storybook:
    Created new stories to demonstrate the functionality of the hideClearButton prop.
    Included examples for both scenarios: with the clear button visible and hidden.

Documentation: Updated the component documentation to include details about the new prop and its usage.

Related Issues
#2377

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: d7c69ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 1, 2024

✅ PR title follows Conventional Commits specification.

@yadavshubham01 yadavshubham01 changed the title Add hideClearButton Prop to SearchInput Component feat: hideClearButton Prop to SearchInput Component Dec 1, 2024
Copy link

codesandbox-ci bot commented Dec 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d7c69ff:

Sandbox Source
razorpay/blade: basic Configuration

Copy link
Contributor

@tewarig tewarig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yadavshubham01,
Thanks for raising this PR
Could you add a test case for hideClearButton? Also, there is one thin one test case is failing. Please pull the latest changes from the master branch, I think it will resolve the issue. Other than that, there are a few linting errors. Could you fix them as well?

@tewarig
Copy link
Contributor

tewarig commented Dec 19, 2024

@yadavshubham01 GitHub Actions still seem to be failing. Can you lint the code once locally?

@yadavshubham01
Copy link
Author

let me fix the linting in code

@yadavshubham01
Copy link
Author

hey @tewarig I fix linting now you checked it

@tewarig
Copy link
Contributor

tewarig commented Dec 22, 2024

@yadavshubham01 can you add changeset ?

@yadavshubham01
Copy link
Author

No

@tewarig tewarig changed the title feat: hideClearButton Prop to SearchInput Component feat: add hideClearButton Prop to SearchInput Component Jan 2, 2025
@tewarig tewarig self-assigned this Jan 3, 2025
@tewarig tewarig added the Review - L2 Second level of review label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - L2 Second level of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants