feat: created magic-cart-vanilla.js #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajsarowicz
suggested changes
Mar 12, 2025
| @@ -46,5 +46,6 @@ $cartDataCount = count($cartData); | |||
| </div> | |||
| <link rel="stylesheet" type="text/css" | |||
| href="<?php echo $block->getViewFileUrl('Razorpay_Magento::css/magic.css'); ?>"> | |||
|
|
|||
| <script type="text/javascript" src="<?php echo $block->getViewFileUrl('Razorpay_Magento::js/magic-cart-vanilla.js'); ?>"> | |||
There was a problem hiding this comment.
type="text/javascript"is redundant,- Use quick echo
- Add missing escaping.
Suggested change
| <script type="text/javascript" src="<?php echo $block->getViewFileUrl('Razorpay_Magento::js/magic-cart-vanilla.js'); ?>"> | |
| <script src="<?= $escaper->escapeUrl($block->getViewFileUrl('Razorpay_Magento::js/magic-cart-vanilla.js')) ?>"> |
| @@ -1,15 +1,23 @@ | |||
| #cart-occ-template { | |||
There was a problem hiding this comment.
The way you introduce CSS changes is incorrect and does not allow proper customization.
Instead, your changes should be located in web/css/_source/_magic.less then included in the _module.less, compiled and minified on the go, instead of causing performance overhead of loading additional CSS files.
| @@ -0,0 +1,385 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
Is there any reason why you don't use UI Components?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.