Use the new rbenv init to set up the user's shell
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because entries in `/opt/rubies` are typically prefixed with "ruby-", but rbenv does not use that prefix. Also, this is a feature of the installer literally no one asked for.
mattbrictson
added a commit
to mattbrictson/tomo
that referenced
this pull request
May 25, 2024
Recently, tomo's `rbenv:install` task has started failing with this output: ``` Installing ruby 3.3.0 -- this may take several minutes CFLAGS=-O3 rbenv install 3.3.0 --verbose bash: line 1: rbenv: command not found ``` This is because rbenv was recently updated[^1] to to automatically add the `rbenv init` script to the `.bashrc` file during installation. However, rbenv adds it to the _bottom_ of the file after the early-exit that skips most of the `.bashrc` when it is sourced in a non-interactive shell (i.e. tomo via SSH). That left rbenv in an installed but broken state; hence the error. Fix by having `rbenv:install` detect this situation and prepend the `rbenv init` script to the _top_ of the file, where it will get loaded for non-interactive shells such as tomo's. [^1]: rbenv/rbenv-installer#50
kodiakhq bot
pushed a commit
to mattbrictson/tomo
that referenced
this pull request
May 25, 2024
Recently, tomo's `rbenv:install` task has started failing with this output: ``` Installing ruby 3.3.0 -- this may take several minutes CFLAGS=-O3 rbenv install 3.3.0 --verbose bash: line 1: rbenv: command not found ``` This is because rbenv was recently updated[^1] to to automatically add the `rbenv init` script to the `.bashrc` file during installation. However, rbenv adds it to the _bottom_ of the file after the early-exit that skips most of the `.bashrc` when it is sourced in a non-interactive shell (i.e. tomo via SSH). That left rbenv in an installed but broken state; hence the error. Fix by having `rbenv:install` detect this situation and prepend the `rbenv init` script to the _top_ of the file, where it will get loaded for non-interactive shells such as tomo's. [^1]: rbenv/rbenv-installer#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rbenv/rbenv#1568