Multiple updates supporting ROs 4542, 4552, 4553, & 4555 #17
Conversation
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { |
There was a problem hiding this comment.
It seems that the pdbx_database_accession is missing
There was a problem hiding this comment.
Thanks for picking this up @valasatava.
This has been addressed in the latest commit. Please review.
| } | ||
| ] | ||
| }, | ||
| "pdbx_DOI": { |
There was a problem hiding this comment.
Do we want to load the DOI as well? I think we're currently building DOIs on the fly in frontend
There was a problem hiding this comment.
Good point @valasatava.
It is an attribute in the public database_2 category. Is it ok to have it in the data warehouse for external users?
There was a problem hiding this comment.
@valasatava do you recommend that we suppress pdbx_DOI explicitly? Or can it be included as is?
There was a problem hiding this comment.
There is no issue with including this item, but I am being cautious about what we expose in the public API. @josemduarte what's your opinion?
There was a problem hiding this comment.
I think it can't hurt to include it. So that we offer the data out to users. But let's not add to search.
There was a problem hiding this comment.
Thanks @josemduarte. There is no search metadata for pdbx_DOI.
This PR addresses the following:
database_2to support extended PDB IDs5.410pdbx_vrpt_summary_geometryrcsb_polymer_instance_feature_summary.coverage