Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Elasticsearch Index Populate Command to prevent invalid shopId #13

Open
wants to merge 2 commits into
base: 5.7
Choose a base branch
from
Open

Optimize Elasticsearch Index Populate Command to prevent invalid shopId #13

wants to merge 2 commits into from

Conversation

reConNico
Copy link
Owner

Make sure that the provided shopId exists in the sw:es:index:populate cli command.

Description

Questions Answers
Why? Providing an invalid shopId to the index populate command breaks it
BC breaks? yes
Tests exists & pass? yes
Related tickets?
How to test? bin/console sw:es:index:populate --shopId={1,22} (test with invalid shopId)
Requirements met? yes

reConNico and others added 2 commits November 16, 2021 10:36
@reConNico
Update IndexPopulateCommand.php
e15f405 
Make sure that the shop exists
@reConNico
phpcs fix
9f254ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reConNico