Document use of pnpm/turbo in readme #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38443ec:
|
|
Had the issue today as I wanted to look into #916, would be lovely if a team member could merge this :) |
|
please check also |
chaance
approved these changes
Sep 27, 2022
|
Went ahead and merged this as the WIP is better than leaving the old docs as-is. Feel free to fill out the rest and open a new PR. Thanks for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #952,
README.mdcurrently directs folks to install and build the project withyarn. The project moved topnpmabout four weeks ago, so contributors will trip up if they follow the installation instructions as is, or realize there's apnpm-lock.yamlfile and not trust the README at all.I've swapped out
yarnforpnpmwhere I can (and also replaced thestartcommand withdevas well). However, the README also details a release process based on the old Lerna flow before moving to Turborepo. I'm not at all sure what the current release process is, so I'm leaving the PR as a draft until I get some feedback.