Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Preact support #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XavierLeTohic
Copy link

Ref #134

You can find a working preact app exemple with rc-form here

Please note that I bypassed pre-commit linter because the installed "preact" and "preact-compat" packages are not used in the code but required to make rc-form works with preact.

@benjycui
Copy link
Member

No package-lock.json, thanks.

And I think you should add test to make sure rc-form works with preact.

@XavierLeTohic
Copy link
Author

With enzyme we need to make aliases of react testing packages to preact testing packages.
But in this case the existing tests will be launch with preact aliases instead of react.

The solution is to write a configuration file only for testing with preact and run another task named "test:preact" that will use this configuration.

Do you know any alternative way to do it ? 🤔

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants