Skip to content

fix: add popupRender to SubMenuType #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afc163 merged 4 commits into from
Jan 26, 2026
+6 −3
Merged

fix: add popupRender to SubMenuType #849

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
847f3e9
fix: add popupRender to SubMenuType
QDyanbing Jan 22, 2026
2286085
chore: remove SubMenuProps popupRender
QDyanbing Jan 23, 2026
93603be
chore: remove unused types from SubMenu
QDyanbing Jan 23, 2026
8f61e08
fix: keep useResizeObserver in resize-observer mock
QDyanbing Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/SubMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Overflow from '@rc-component/overflow';
import warning from '@rc-component/util/lib/warning';
import SubMenuList from './SubMenuList';
import { parseChildren } from '../utils/commonUtil';
import type { MenuInfo, SubMenuType, PopupRender } from '../interface';
import type { MenuInfo, SubMenuType } from '../interface';
import MenuContextProvider, { MenuContext } from '../context/MenuContext';
import useMemoCallback from '../hooks/useMemoCallback';
import PopupTrigger from './PopupTrigger';
Expand Down Expand Up @@ -38,7 +38,6 @@ export interface SubMenuProps extends Omit<SubMenuType, 'key' | 'children' | 'la

/** @private Do not use. Private warning empty usage */
warnKey?: boolean;
popupRender?: PopupRender;
// >>>>>>>>>>>>>>>>>>>>> Next Round <<<<<<<<<<<<<<<<<<<<<<<
// onDestroy?: DestroyEventHandler;
}
Expand Down
1 change: 1 addition & 0 deletions src/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface SubMenuType extends ItemSharedProps {
popupClassName?: string;
popupOffset?: number[];
popupStyle?: React.CSSProperties;
popupRender?: PopupRender;

// >>>>> Events
onClick?: MenuClickEventHandler;
Expand Down
Loading