Skip to content

feat: new hook useClickOutside #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2021
Merged

feat: new hook useClickOutside #147

merged 2 commits into from
Jun 24, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 23, 2021

What new hook does?

Triggers callback when user clicks outside the target element.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the 🎂 new hook New hook added label Jun 23, 2021
@xobotyi xobotyi requested a review from JoeDuncko June 23, 2021 23:15
@codecov
Copy link

codecov bot commented Jun 23, 2021 •
edited
Loading

Codecov Report

Merging #147 (5c494b6) into master (003b8e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        39    +3     
  Lines          567       626   +59     
  Branches       104       112    +8     
=========================================
+ Hits           567       626   +59
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useClickOutside/useClickOutside.ts 100.00% <100.00%> (ø)
src/useEventListener/useEventListener.ts 100.00% <100.00%> (ø)
src/usePermission/usePermission.ts 100.00% <100.00%> (ø)
src/util/misc.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c2c4b...5c494b6. Read the comment docs.

@xobotyi xobotyi mentioned this pull request Jun 23, 2021
Open
@xobotyi xobotyi merged commit 3dece07 into master Jun 24, 2021
@xobotyi xobotyi deleted the useClickOutside branch June 24, 2021 19:22
github-actions bot pushed a commit that referenced this pull request Jun 24, 2021
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
95cf9c3 
# [3.4.0](v3.3.0...v3.4.0) (2021-06-24)

### Features

* new hook `useClickOutside` ([#147](#147)) ([3dece07](3dece07))
* new hook `useSet` ([#154](#154)) ([f1d781c](f1d781c))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jun 24, 2021

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko